Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if email is used when updating user #21289

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Check if email is used when updating user #21289

merged 6 commits into from
Sep 29, 2022

Conversation

ridnlee
Copy link
Contributor

@ridnlee ridnlee commented Sep 28, 2022

Fix #21075
When updating user data should check if email is used by other users

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 28, 2022
@6543 6543 added this to the 1.18.0 milestone Sep 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 29, 2022
wxiaoguang
wxiaoguang previously approved these changes Sep 29, 2022
View reviewed changes
wxiaoguang
wxiaoguang reviewed Sep 29, 2022
View reviewed changes
models/user/user.go Outdated Show resolved Hide resolved
@wxiaoguang wxiaoguang dismissed their stale review September 29, 2022 10:21

A small question (I haven't got time to think about it ....)

@wxiaoguang wxiaoguang added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Sep 29, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 29, 2022
@ridnlee ridnlee requested review from 6543 and wxiaoguang and removed request for 6543 September 29, 2022 11:10
@6543 6543 merged commit 1d3095b into go-gitea:main Sep 29, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 30, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
6ca2711 
* upstream/main:
  Add pages to view watched repos and subscribed issues/PRs (go-gitea#17156)
  Fix the hook related FAQ contents (go-gitea#21297)
  Check if email is used when updating user (go-gitea#21289)
  Add name field for org api (go-gitea#21270)
  Add API endpoint to get changed files of a PR (go-gitea#21177)
@lunny
Copy link
Member

lunny commented Oct 24, 2022

Please send backport

@ghost ghost mentioned this pull request Nov 10, 2022
Closed
@lunny lunny added the backport/done All backports for this PR have been created label Nov 10, 2022
@6543 6543 added outdated/backport/v1.18 This PR should be backported to Gitea 1.18 and removed backport/done All backports for this PR have been created labels Nov 12, 2022
@jolheiser jolheiser removed backport/v1.17 outdated/backport/v1.18 This PR should be backported to Gitea 1.18 labels Jan 13, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

EditUserPost doesn't check email
6 participants
@ridnlee @lunny @wxiaoguang @6543 @GiteaBot @jolheiser