Add option to change username to the admin panel #2129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
requested changes
Jul 9, 2017
lunny
added
the
type/feature
|
@lafriks added |
tboerger
added
the
lgtm/need 2
lafriks
approved these changes
Jul 9, 2017
|
Integration test would be nice for this |
ethantkoenig
suggested changes
Jul 10, 2017
bkcsoft
suggested changes
Jul 12, 2017
Bwko
force-pushed
the
change_username
branch
2 times, most recently
from
8636454 to
42357e4
Compare
|
@lafriks I've added some tests |
|
This one is ready for review |
lunny
requested changes
Oct 26, 2017
| @@ -205,6 +205,14 @@ func EditUserPost(ctx *context.Context, form auth.AdminEditUserForm) { | |||
| u.EncodePasswd() | |||
| } | |||
|
|
|||
| if u.IsLocal() && len(form.UserName) > 0 && u.Name != form.UserName { | |||
| if err := models.ChangeUserName(u, form.UserName); err != nil { | |||
There was a problem hiding this comment.
I think models.ChangeUserName and models.UpdateUser should be with a transaction.
There was a problem hiding this comment.
@Bwko any update for this?
bkcsoft
approved these changes
Oct 29, 2017
bkcsoft
added
lgtm/done
|
@Bwko what's the state? |
|
state of this pr? |
|
followup: #14229 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds #1818