Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deleted repos from searchresult #21512

Merged
merged 6 commits into from
Oct 22, 2022

Conversation

RaymondKroon
Copy link
Contributor

@RaymondKroon RaymondKroon commented Oct 19, 2022

This prevents a 500 response, because null pointer exceptions in rendering the template.
This happends bc the repoId is not in the repoMap because it is delete

fix #19076

This prevents a 500 result, because null pointer exceptions in rendering the template. This happends bc the repoId is not in the repoMap because it is delete (or archived?)
@RaymondKroon

This comment was marked as duplicate.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 19, 2022
@lunny lunny added type/enhancement An improvement of existing functionality backport/v1.17 labels Oct 19, 2022
@lunny
Copy link
Member

lunny commented Oct 19, 2022

The index in fact will be deleted in index notification system. But it will take some time. So this will be a temporary resolution.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 19, 2022
@RaymondKroon
Copy link
Contributor Author

RaymondKroon commented Oct 19, 2022

The index in fact will be deleted in index notification system. But it will take some time. So this will be a temporary resolution.

You mean temporary as in removing this fix, or temporary as in the time that the index contains non existing repoIDs?
Because unless the index deletion is completely synchronous, this check will still be needed?

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 20, 2022
@6543 6543 added this to the 1.18.0 milestone Oct 21, 2022
@6543 6543 added type/bug and removed type/enhancement An improvement of existing functionality labels Oct 21, 2022
@lunny
Copy link
Member

lunny commented Oct 22, 2022

make L-G-T-M work.

@lunny lunny merged commit 69fcca2 into go-gitea:main Oct 22, 2022
@lunny
Copy link
Member

lunny commented Oct 24, 2022

Please send backport

zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 24, 2022
* upstream/main:
  adapt README_{Country}.md stype name in localizedExtensions (go-gitea#21486)
  dump: Add option to skip index dirs (go-gitea#21501)
  Use recommended vscode configuration in gitpod environments (go-gitea#21537)
  Expand "Go to File" button again, fix 'Add File' margin (go-gitea#21543)
  Add yardenshoham to maintainers (go-gitea#21566)
  Refactor git command arguments and make all arguments to be safe to be used (go-gitea#21535)
  Update binding to fix bugs (go-gitea#21556)
  Link mentioned user in markdown only if they are visible to viewer (go-gitea#21554)
  Require authentication for OAuth token refresh (go-gitea#21421)
  CSS color enhancements (go-gitea#21534)
  Allow package version sorting (go-gitea#21453)
  Add link to user profile in markdown mention only if user exists (go-gitea#21533)
  Update milestone counters when issue is deleted (go-gitea#21459)
  Prevent Authorization header for presigned LFS urls (go-gitea#21531)
  Remove deleted repos from searchresult (go-gitea#21512)
  Remove unnecessary debug log (go-gitea#21536)
  Added check for disabled Packages (go-gitea#21540)
  Decouple HookTask from Repository (go-gitea#17940)
  Add color previews in markdown (go-gitea#21474)
  Fix generating compare link (go-gitea#21519)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP 500 on explore/code search after repo delete (with enabled code indexer via elasticsearch)
6 participants