Align label with checkbox #21660
Closed
Align label with checkbox #21660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gusted
commented
Nov 2, 2022
Gusted
commented
- Follow up from Configure update checker on installation page #21655 (comment)
- Use vertical-align and line-height to get it to align exactly with the checkbox.
- Follow up from go-gitea#21655 (comment) - Use vertical-align and line-height to get it to align exactly with the checkbox.
Gusted
added
skip-changelog
|
Take a look at other checkbox code. IIRC it should be like this: No more CSS style / ID / FOR is needed. |
GiteaBot
added
the
lgtm/need 2
|
That doesn't work, the current CSS always makes that the checkbox is left of the label(which for sake of consistency is not something we want) and there would be no label directly under the ` to add the correct amount of padding to align the field.
|
|
It should work. I made a fix. The problem was that the width of
|
|
I'm not a big fan of moving the helper text inside |
wxiaoguang
force-pushed
the
align-label
branch
from
dd91b71
to
511e011
Compare
|
I reverted my changes. But the Maybe let other maintainers to decide. |
6543
approved these changes
Nov 2, 2022
GiteaBot
added
lgtm/need 1
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Nov 2, 2022
The install page has been somewhat inconsistently styled for a while. This PR simplifies and standardises the styling of these fields makes things line up better across widths. Replace go-gitea#21660 Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added a commit
that referenced
this pull request
Nov 3, 2022
The install page has been somewhat inconsistently styled for a while. This PR simplifies and standardises the styling of these fields makes things line up better across widths. Replace #21660 Signed-off-by: Andrew Thornton <art27@cantab.net> Old:  New:  Signed-off-by: Andrew Thornton <art27@cantab.net>
|
Replaced by #21668 |
|
Thanks @Gusted for spurring me to look at this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.