On tag/branch-exist check, dont panic if repo is nil #21787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
added
type/bug
backport/v1.17
outdated/backport/v1.18
This was referenced Nov 12, 2022
GiteaBot
added
the
lgtm/need 2
6543
added
backport/done
|
It's better to do the check out of the method. |
GiteaBot
added
the
lgtm/need 2
|
you mean check what func did call this in the first place? |
|
zeripath
approved these changes
Nov 13, 2022
GiteaBot
added
lgtm/need 1
|
@6543 the logging surrounding this PANIC would have been helpful as Would have written a start event at line 122 and an end event in its defer. However, we can see this is related to The context of which is: And we see that the gitRepo should not be nil here. So I don't understand how this can happen. |
|
right! but it did :/ |
|
a1012112796
approved these changes
Nov 27, 2022
GiteaBot
added
lgtm/done
|
It would still be really useful to figure out how ctx.Repo.GitRepo was nil here. I have a feeling that the there was an error higher up that didn't get handled properly. It would be really helpful to get the context for the logs i.e check if there were any other log lines for [636fd44c-60] |
|
Aha! I have understood the problem: Here You are running the API GetBranch call on an "empty" repository. Now, I have a feeling that this code should be handling the error condition itself but maybe I'm wrong and we want the API endpoints to have to check for empty repos themselves BUT I would have thought that if an API wanted to deal with empty repos it would indicate that by using Following this reasoning this PR is not really correct and instead we should be getting the GetBranch endpoint to check for empty OR make ReferencesGitRepo error out if there is an empty repo. |
|
make lgtm work |
zeripath
pushed a commit
that referenced
this pull request
Dec 4, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 5, 2022
* giteaofficial/main: Ensure that Chinese punctuation is not ambiguous when locale is Chinese (go-gitea#22019) Use GhostUser if needed for TrackedTimes (go-gitea#22021) Add dumb-init to rootless docker (go-gitea#21775) On tag/branch-exist check, dont panic if repo is nil (go-gitea#21787) Fix ListBranches to handle empty case (go-gitea#21921) fix(web): reduce page jitter on browsers that support overlay scrollbar (go-gitea#21850) [skip ci] Updated licenses and gitignores Do not emit ambiguous character warning on rendered pages (go-gitea#22016)
lunny
added a commit
that referenced
this pull request
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a panic found in gitea logs