-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace yaml.v2 with yaml.v3 #21832
Replace yaml.v2 with yaml.v3 #21832
Conversation
Related: |
that wont work as long as goldmark do use the old one |
I might know why, v2 will decode a map into interface with type Not really sure, I'll take some time to figure it out. |
I saw your attempt in yuin/goldmark-meta#6. But I mean avoid using both versions in Gitea directly, I know we can't get rid of v2 version completely. |
But at least, we can remove all direct dependencies on v2. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There are two little differences between yaml.v2 and yaml.v3 which broke the tests:
There's an example: https://go.dev/play/p/PqLD6tR75xF . |
I don't see why we have to use two versions of yaml. The difference between the two versions has nothing to do with our usage.
* giteaofficial/main: Handle empty author names (go-gitea#21902) Move all remaining colors into CSS variables (go-gitea#21903) Add option to enable CAPTCHA validation for login (go-gitea#21638) Prepend refs/heads/ to issue template refs (go-gitea#20461) Fixes go-gitea#21895: standardize UTC tz for util tests (go-gitea#21897) Clarify logging documentation (go-gitea#21665) Update JS dependencies (go-gitea#21881) Webhook list enhancements (go-gitea#21893) Embed Matrix icon as SVG (go-gitea#21890) fix(web): add `alt` for logo in home page (go-gitea#21887) Improvements for Content Copy (go-gitea#21842) Replace yaml.v2 with yaml.v3 (go-gitea#21832) Allow disable RSS/Atom feed (go-gitea#21622) Consolidate security-check into checks-backend (go-gitea#21882)
I don't see why we have to use two versions of yaml. The difference between the two versions has nothing to do with our usage.