Change ID pattern of raw content container for issue

[fsologureng]

Implement differentiation to html id for issue raw content container.

Fixes #21965

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@f047ee0). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #21966   +/-   ##
=======================================
  Coverage        ?   48.14%           
=======================================
  Files           ?     1037           
  Lines           ?   141357           
  Branches        ?        0           
=======================================
  Hits            ?    68052           
  Misses          ?    65165           
  Partials        ?     8140           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[silverwind]

Something is wrong here, you seem to have commited a .patch file instead of editing the actual file.

[fsologureng]

Something is wrong here, you seem to have commited a .patch file instead of editing the actual file.

Excuse me. You are right. I think it's ready now.

[fsologureng]

Thanks for reviewing @silverwind.

[silverwind]

Are you sure this won't break any comment-* links?

[fsologureng]

Are you sure this won't break any comment-* links?

Ok. I finally understand how things work for quotes. I hope the fix is correct this time.
Thank you very much for your time.

[zeripath]

So the problem here is that people may have written links in their comments looking to link to commit-$COMMENT_ID and these will now break.

Is it really necessary to add the raw- prefix and instead only change the link to the issue message to issue-$ID instead?

[silverwind]

I don't understand the original issue but I think if we change all the comment- ids, it'd break all existing links to comments, so this seems like a definitive no-go to me. We must maintain compatibility.

[fsologureng]

@zeripath: So the problem here is that people may have written links in their comments looking to link to commit-$COMMENT_ID and these will now break.

@silverwind: I think if we change all the comment- ids, it'd break all existing links to comments, so this seems like a definitive no-go to me. We must maintain compatibility.

The proposed ID change is for the raw content inside issues and comments (required for quoting before doing post), not for the issue ID itself nor the comment ID itself. Those IDs (for linking) remain intact in the templates in the data-reference attribute.

[fsologureng]

I don't understand the original issue

The problem is a collision between html IDs of raw-content of an issue and a single one of its comments, because their current html ID prefix (comment-) is the same for both. So, taking into account the fact that is possible that equals internal ID (one from the issue and the other from any of its comments) appears in the same page, the unwanted behaviour is that quoting to reply or quoting for a new issue with a reference, takes a quoted text that belongs to the other object (issue or comment, respectively).

[fsologureng]

I updated the commit:

• Adding 3 more template points. There are 5 types of comment.
• Redefining the new ID following suffix notation (-raw) of other auxiliar IDs (-write, -preview) of comments.
• Changing javascript quoting functions making them agnostics about data-target value structure which is now self-contained.

[wxiaoguang]

Could .HashTag be used here instead of .ID?

The problem of using "issuecomment-{{.ID}}-raw" here is: it introduces inconsistency, future developers won't understand easily that data-target="{{.item.HashTag}}-raw" means something like "issuecomment-{{.ID}}-raw".

[fsologureng]

It could be, but the line immediately following has a data-write="issuecomment-{{.ID}}-write" attribute (which I think will also leave an inconsistency) and, on the other hand, the data-target="{{.item.HashTag}}-raw" attribute means either "issuecomment-{.ID}}-raw" or "issue-{.ID}}-raw" depending on the context.

Update: Maybe another PR could change all the "issuecomment-{.ID}}-suffix" as "{{.HashTag}}-suffix" of the template for consistency.

[wxiaoguang]

Hmm yup, it was messy already. 😂 It could LGTM.

[wxiaoguang]

I don't understand the original issue but I think if we change all the comment- ids, it'd break all existing links to comments, so this seems like a definitive no-go to me. We must maintain compatibility.

These IDs are for "hidden" texts (to be quoted later), it won't break anything IMO.