Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin and alignment in dashboard repolist (#22120) #22122

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

silverwind
Copy link
Member

Backport #22120 to 1.18. Seems this has recently regressed, previously, there was a significant whitespace between icon and text, but it seems to be gone, so I added the margin.

Seems this has recently regressed, previously, there was a significant
whitespace between icon and text, but it seems to be gone, so I added
the margin.
@silverwind silverwind added this to the 1.18.0 milestone Dec 13, 2022
@silverwind silverwind added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI labels Dec 13, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 14, 2022
@techknowlogick techknowlogick changed the title Fix margin and alignment in dashboard repolist Fix margin and alignment in dashboard repolist (#22120) Dec 14, 2022
@silverwind silverwind marked this pull request as draft December 14, 2022 08:44
@silverwind
Copy link
Member Author

Putting in draft, need to fix text truncation in the flexbox.

@silverwind silverwind marked this pull request as ready for review December 15, 2022 21:10
@silverwind
Copy link
Member Author

Ready again, truncation fix applied.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 16, 2022
@KN4CK3R KN4CK3R merged commit 4297ace into go-gitea:release/v1.18 Dec 16, 2022
@silverwind silverwind deleted the backport-22120 branch December 16, 2022 19:58
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants