-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update libcurl in docs pipeline #22203
Conversation
Signed-off-by: jolheiser <john.olheiser@gmail.com>
Why? |
Otherwise Our docs pipeline started to fail recently when If there is a better way, I am open to it. EDIT: I updated my PR description for clarification, as discussion happened in Discord. |
Huh, looks like curl is seriously broken inside that container. Must be some global config or something, not sure. Do you know where the source Dockerfile for this image lives?
|
It comes from https://github.com/drone-plugins/drone-hugo/blob/master/docker/Dockerfile.linux.arm64 Of note, the image it uses as a base, |
Issue is curl and libcurl do not match inside the image. Cause unknown, that Dockerfile does not deal with curl. Some layer before might have installed the old
|
Co-authored-by: silverwind <me@silverwind.io>
Opened drone-plugins/drone-hugo#36 to track upstream. |
Co-authored-by: silverwind <me@silverwind.io>
Backport #22203 Signed-off-by: jolheiser <john.olheiser@gmail.com> Co-authored-by: silverwind <me@silverwind.io>
🎺 🤖 |
Backport #22203 Signed-off-by: jolheiser <john.olheiser@gmail.com>
BTW we should probably just run hugo in a regular
|
#22206 for that. |
* giteaoffical/main: (32 commits) Hide file borders on sticky diff box (go-gitea#22217) Test views of LFS files (go-gitea#22196) update docs latest to 1.17.4 Frontport 1.17.4 changelog (go-gitea#22216) Remove test session cache to reduce possible concurrent problem (go-gitea#22199) Upgrade hugo to 0.82 (go-gitea#22209) Fix container layer display overflow (go-gitea#22208) Run hugo via `go run` and lock its version (go-gitea#22206) Update bleve and zapx to fix unaligned atomic (go-gitea#22031) Allow empty assignees on pull request edit (go-gitea#22150) Add Feed for Releases and Tags (go-gitea#21696) fix: update libcurl in docs pipeline (go-gitea#22203) Fixed colour transparency regex matching in project board sorting (go-gitea#22091) (go-gitea#22092) Mobile fix for Project view: Add delay to Sortable.js on mobile, to ensure scrolling is possible. (go-gitea#22152) Normalize NuGet package version on upload (go-gitea#22186) Attempt to fix TestExportUserGPGKeys (go-gitea#22159) Specify ID in `TestAPITeam` (go-gitea#22192) Repair LFS web rendering. (go-gitea#22195) Fix misc whitespace issues in install docs (go-gitea#22189) Update JS dependencies and eslint (go-gitea#22190) ...
Our docs pipeline has been failing recently, and running the image locally without
-s
showsAdding
curl-dev
appears to fix the issue.Per @silverwind instead we can just update
libcurl
to make them match.