Fix bug of DisableGravatar default value #22296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
type/bug
outdated/backport/v1.18
delvh
approved these changes
Dec 31, 2022
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #22296 +/- ##
=======================================
Coverage ? 48.15%
=======================================
Files ? 1043
Lines ? 142404
Branches ? 0
=======================================
Hits ? 68575
Misses ? 65645
Partials ? 8184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
We should check/enforce the positive form of settings. So |
KN4CK3R
approved these changes
Jan 1, 2023
GiteaBot
added
lgtm/done
|
make L-G-T-M work |
lunny
added a commit
that referenced
this pull request
Jan 1, 2023
backport #22296 Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 3, 2023
* upstream/main: Add deprecated warning for DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR (go-gitea#22318) Unify hashing for avatar (go-gitea#22289) fix: code search title translation (go-gitea#22285) Update Gmail mailer configuration (go-gitea#22291) Fix due date rendering the wrong date in issue (go-gitea#22302) Fix get system setting bug when enabled redis cache (go-gitea#22295) Restructure `webhook` module (go-gitea#22256) Reminder for no more logs to console (go-gitea#22282) Fix bug of DisableGravatar default value (go-gitea#22296) Upgrade go-chi to v5.0.8 (go-gitea#22304) [skip ci] Updated licenses and gitignores Use ErrInvalidArgument in packages (go-gitea#22268) Changelog v1.18.0 (go-gitea#22215) (go-gitea#22269) Support estimated count with multiple schemas (go-gitea#22276) Add Gentoo to the from package providers (go-gitea#22284) Fix sitemap (go-gitea#22272) Add `sync_on_commit` option for push mirrors api (go-gitea#22271) Fix key signature error page (go-gitea#22229)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18058 made a mistake. The disableGravatar's default value depends on
OfflineMode. If it'strue, thendisableGravataris true, otherwise it'sfalse. But not opposite.