Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deprecated warning for DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR (#22318) #22324

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Add deprecated warning for DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR (#22318) #22324

merged 1 commit into from
Jan 3, 2023

Conversation

kdumontnu
Copy link
Contributor

Backport #22318

@kdumontnu kdumontnu changed the title Add deprecated warning Add deprecated warning for DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR Jan 3, 2023
@jolheiser
Copy link
Member

Until we have versioned docs I don't think this is really required. Is there a benefit? (There's no harm, of course, just curious)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 3, 2023
@kdumontnu
Copy link
Contributor Author

Until we have versioned docs I don't think this is really required. Is there a benefit? (There's no harm, of course, just curious)

Ah, okay I thought versioned docs was supported (or about to be) given the conversations in discord.

@jolheiser
Copy link
Member

Until we have versioned docs I don't think this is really required. Is there a benefit? (There's no harm, of course, just curious)

Ah, okay I thought versioned docs was supported (or about to be) given the conversations in discord.

There's the prototype, but I don't know how close that is to prod. I think, since this doesn't harm anything, we may as well take the optimistic approach.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2023
@jolheiser jolheiser added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 3, 2023
@jolheiser jolheiser added this to the 1.18.1 milestone Jan 3, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2023
@techknowlogick techknowlogick merged commit 5b87634 into go-gitea:release/v1.18 Jan 3, 2023
@kdumontnu kdumontnu deleted the kd/docs-update_avatar_config_backport_1_18 branch January 3, 2023 16:25
@zeripath zeripath changed the title Add deprecated warning for DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR Add deprecated warning for DISABLE_GRAVATAR and ENABLE_FEDERATED_AVATAR (#22318) Jan 17, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.18.1
Development

Successfully merging this pull request may close these issues.
5 participants
@kdumontnu @jolheiser @lunny @techknowlogick @GiteaBot