Update Emoji dataset to Unicode 14 #22342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitea emoji dataset was out of date because it gets manually build and hasn't been rebuilt since it was added. This means Gitea doesn't recognize some newer emoji or changes to existing ones. After changing the max unicode version to 14 I just ran: `go run build/generate-emoji.go` This should address the initial issue seen in go-gitea#22153 where Gitea doesn't recognize a standard alias used elsewhere when importing content. 14 is the latest supported version from the upstream source as 15 is not widely supported (in their opinion) yet: github/gemoji#244 (comment)
jolheiser
approved these changes
Jan 4, 2023
GiteaBot
added
the
lgtm/need 1
|
fwiw I'm fine with this being backported to 1.18 as a simple dep change. |
jolheiser
added
the
outdated/backport/v1.18
delvh
approved these changes
Jan 4, 2023
GiteaBot
added
lgtm/done
|
Feel free to backport, or I can if you would prefer! 🤝 |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this pull request
Jan 4, 2023
Gitea emoji dataset was out of date because it gets manually built and hasn't been rebuilt since it was added. This means Gitea doesn't recognize some newer emoji or changes to existing ones. After changing the max unicode version to 14 I just ran: `go run build/generate-emoji.go` This should address the initial issue seen in go-gitea#22153 where Gitea doesn't recognize a standard alias used elsewhere when importing content. 14 is the latest supported version from the upstream source as 15 is not widely supported (in their opinion) yet
Thx! I Created backport (had to remember how 😅 |
jolheiser
pushed a commit
that referenced
this pull request
Jan 4, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 5, 2023
* upstream/main: Rewrite fuzzers to native Go harnesses (go-gitea#22313) Update Emoji dataset to Unicode 14 (go-gitea#22342) fix gravatar disable bug (go-gitea#22336)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitea emoji dataset was out of date because it gets manually built and hasn't been rebuilt since it was added. This means Gitea doesn't recognize some newer emoji or changes to existing ones.
After changing the max unicode version to 14 I just ran:
go run build/generate-emoji.goThis should address the initial issue seen in #22153 where Gitea doesn't recognize a standard alias used elsewhere when importing content.
14 is the latest supported version from the upstream source as 15 is not widely supported (in their opinion) yet: github/gemoji#244 (comment)