Add multi delete issues #22344
Add multi delete issues #22344
Conversation
GiteaBot
added
the
lgtm/need 1
|
Thanks I forgot that gitpod can do this too |
| @@ -171,6 +171,7 @@ | |||
| {{else}} | |||
| <div class="ui red active basic button issue-action" data-action="close" data-url="{{$.RepoLink}}/issues/status" style="margin-left: auto">{{.locale.Tr "repo.issues.action_close"}}</div> | |||
| {{end}} | |||
| <div class="ui negative active button issue-action" data-action="delete" data-url="{{$.RepoLink}}/issues/status" style="margin-left: auto">{{.locale.Tr "repo.issues.delete"}}</div> | |||
There was a problem hiding this comment.
I'm strongly against allowing such a destructive action to occur without presenting a warning dialogue.
At best, extract the existing issue deletion dialogue into a new template and reuse it, or copy it if that's not easily possible.
There was a problem hiding this comment.
In addition, why display a text when it's probably a better idea to use the octicon-trash SVG instead?
First of all to minimize the user potential to missclick there, and secondly to improve the UX.
| @@ -29,7 +29,7 @@ | |||
| {{end}} | |||
| <div class="ui divider"></div> | |||
| <a class="{{if not $.RepoIDs}}ui basic primary button{{end}} repo name item" href="{{$.Link}}?type={{$.ViewType}}&sort={{$.SortType}}&state={{$.State}}&q={{$.Keyword}}"> | |||
| <span class="text truncate">All</span> | |||
| <span class="text truncate">{{.locale.Tr "all"}}</span> | |||
There was a problem hiding this comment.
This change seems oddly familiar… 😉
| func DeleteIssues(doer *user_model.User, gitRepo *git.Repository, issues []*issues_model.Issue) error { | ||
| for _, issue := range issues { | ||
| if err := DeleteIssue(doer, gitRepo, issue); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Hmm, we could think about passing a context in as well and executing this whole block inside a transaction so that it is automatically rolled back if the deletion of any issue fails.
And there are some open review comments, is this PR active? |
wxiaoguang
added
the
issue/needs-feedback
|
I'm currently very busy, feel free to close this for now |
|
Thank you very much for your contribution. If you don't mind, maybe some some contributors or I could pick it? |
Clarify the "link-action" behavior: > // A "link-action" can post AJAX request to its "data-url" > // Then the browser is redirect to: the "redirect" in response, or "data-redirect" attribute, or current URL by reloading. And enhance the "link-action" to support showing a modal dialog for confirm. A similar general approach could also help PRs like #22344 (comment) > // If the "link-action" has "data-modal-confirm(-html)" attribute, a confirm modal dialog will be shown before taking action. And a lot of duplicate code can be removed now. A good framework design can help to avoid code copying&pasting. --------- Co-authored-by: silverwind <me@silverwind.io>
|
Replaced by Batch delete issue and improvie tippy opts #25253 Major changes:
|
Closes #22273
I couldn't test it because make does not like me.