Skip to content

Address feedback from #22517 #22563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2023
Merged

Address feedback from #22517 #22563

merged 1 commit into from
Jan 22, 2023

Conversation

fsiddi
Copy link
Contributor

@fsiddi fsiddi commented Jan 21, 2023

  • use octicons for icon
  • use fomantic for centering the link

@fsiddi
Address feedback from go-gitea#22517
0aa1273 
- use octicons for icon
- use fomantic for centering the link
@KN4CK3R KN4CK3R added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 21, 2023
@KN4CK3R KN4CK3R added this to the 1.19.0 milestone Jan 21, 2023
techknowlogick
techknowlogick approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fsiddi

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 22, 2023
@techknowlogick
Copy link
Member

For others reviewing, here is a screenshot:
image

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Jan 22, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 22, 2023
@jolheiser jolheiser merged commit 920ae23 into go-gitea:main Jan 22, 2023
@fsiddi fsiddi deleted the dropzone-copy-link-feedback branch January 29, 2023 22:26
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fsiddi @techknowlogick @jolheiser @KN4CK3R @GiteaBot