Fix delete_repo in template
#22606
Merged
Fix delete_repo in template
#22606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jolheiser <john.olheiser@gmail.com>
jolheiser
added
type/bug
topic/ui
|
Can you give a bit of background/context here? Why |
GiteaBot
added
the
lgtm/need 2
Ah, sorry. It has to match the model, otherwise selecting it ends up being a 500 error. gitea/models/auth/token_scope.go Line 42 in e8ac6a9 I've edited the original description for clarity as well, thanks for the nudge! |
yardenshoham
approved these changes
Jan 26, 2023
GiteaBot
added
lgtm/need 1
delvh
approved these changes
Jan 26, 2023
GiteaBot
added
lgtm/done
|
🎺 🤖 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 28, 2023
* giteaofficial/main: (42 commits) Link issue and pull requests status change in UI notifications directly to their event in the timelined view. (go-gitea#22627) fix permission check for creating comment while mail (go-gitea#22524) Fix error on account activation with wrong passwd (go-gitea#22609) Fixes accessibility of empty repository commit status (go-gitea#22632) Use `--index-url` in PyPi description (go-gitea#22620) Show migration validation error (go-gitea#22619) Allow issue templates to not render title (go-gitea#22589) Fix `delete_repo` in template (go-gitea#22606) set org visibility class to basic in header (go-gitea#22605) Add API endpoint to get latest release (go-gitea#21267) Add ARIA support for Fomantic UI checkboxes (go-gitea#22599) Webhooks: for issue close/reopen action, add commit ID that caused it (go-gitea#22583) Add templates to customize text when creating and migrating repositories Prevent duplicate labels when importing more than 99 (go-gitea#22591) Remove address from DCO (go-gitea#22595) Allow setting `redirect_to` cookie on OAuth login (go-gitea#22594) Project links should use parent link methods (go-gitea#22587) link update in README files (go-gitea#22582) Frontport 1.18.2 and 1.18.3 Changelogs (go-gitea#22580) Fix incorrect Redis URL snippets in the example app.ini (go-gitea#22573) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the value doesn't match the model, so selecting it results in a 500.
gitea/models/auth/token_scope.go
Line 42 in e8ac6a9
I also feel like this should be moved up nearer the other repo scopes.
Would anyone be opposed to a follow-up PR for that? (or I can do it in this one yet)