Skip to content

Fixes accessibility behavior of Watching, Staring and Fork buttons #22634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 31, 2023
Merged

Fixes accessibility behavior of Watching, Staring and Fork buttons #22634

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8a3acf2
Fixes accessibility behavior of Watching, Staring and Fork buttons
fsologureng Nov 26, 2022
2ad9793
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 28, 2023
e819dde
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 28, 2023
7e12d38
Merge branch 'main' into gitea-fix-a11y-repo-buttons
fsologureng Jan 29, 2023
cd89361
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 29, 2023
0dce541
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 29, 2023
7703362
Merge branch 'main' into gitea-fix-a11y-repo-buttons
fsologureng Jan 29, 2023
0ecf644
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 30, 2023
6dcedd6
Merge branch 'main' into gitea-fix-a11y-repo-buttons
fsologureng Jan 30, 2023
0626d07
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 31, 2023
5eb1ca6
Merge branch 'main' into gitea-fix-a11y-repo-buttons
lunny Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions templates/repo/header.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
{{end}}
<form method="post" action="{{$.RepoLink}}/action/{{if $.IsWatchingRepo}}un{{end}}watch?redirect_to={{$.Link}}">
{{$.CsrfTokenHtml}}
<div class="ui labeled button{{if not $.IsSigned}} tooltip{{end}}" tabindex="0"{{if not $.IsSigned}} data-content="{{$.locale.Tr "repo.watch_guest_user"}}" data-position="top center"{{end}}>
<div class="ui labeled button{{if not $.IsSigned}} tooltip{{end}}"{{if not $.IsSigned}} data-content="{{$.locale.Tr "repo.watch_guest_user"}}" data-position="top center"{{end}}>
<button type="submit" class="ui compact small basic button"{{if not $.IsSigned}} disabled{{end}}>
{{if $.IsWatchingRepo}}{{svg "octicon-eye-closed" 16}}{{$.locale.Tr "repo.unwatch"}}{{else}}{{svg "octicon-eye"}}{{$.locale.Tr "repo.watch"}}{{end}}
</button>
Expand All @@ -80,7 +80,7 @@
{{if not $.DisableStars}}
<form method="post" action="{{$.RepoLink}}/action/{{if $.IsStaringRepo}}un{{end}}star?redirect_to={{$.Link}}">
{{$.CsrfTokenHtml}}
<div class="ui labeled button{{if not $.IsSigned}} tooltip{{end}}" tabindex="0"{{if not $.IsSigned}} data-content="{{$.locale.Tr "repo.star_guest_user"}}" data-position="top center"{{end}}>
<div class="ui labeled button{{if not $.IsSigned}} tooltip{{end}}"{{if not $.IsSigned}} data-content="{{$.locale.Tr "repo.star_guest_user"}}" data-position="top center"{{end}}>
<button type="submit" class="ui compact small basic button"{{if not $.IsSigned}} disabled{{end}}>
{{if $.IsStaringRepo}}{{svg "octicon-star-fill"}}{{$.locale.Tr "repo.unstar"}}{{else}}{{svg "octicon-star"}}{{$.locale.Tr "repo.star"}}{{end}}
</button>
Expand All @@ -100,7 +100,7 @@
{{else if and (not $.CanSignedUserFork) (eq (len $.UserAndOrgForks) 0)}}
data-content="{{$.locale.Tr "repo.fork_from_self"}}"
{{end}}
data-position="top center" tabindex="0">
data-position="top center">
<a class="ui compact{{if $.ShowForkModal}} show-modal{{end}} small basic button"
{{if not $.CanSignedUserFork}}
{{if gt (len $.UserAndOrgForks) 1}}
Expand Down