Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain that the no-access team unit does not affect public repositories #22661

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Explain that the no-access team unit does not affect public repositories #22661

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8aa94c4
add team unit helper
yp05327 Jan 30, 2023
4cd12b3
remove team unit helper
yp05327 Jan 30, 2023
6d746c6
add tip to team none access helper
yp05327 Jan 30, 2023
8dc5935
Merge branch 'main' into add-team-unit-helper
wolfogre Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions options/locale/locale_en-US.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2371,6 +2371,7 @@ team_desc_helper = Describe the purpose or role of the team.
team_access_desc = Repository access
team_permission_desc = Permission
team_unit_desc = Allow Access to Repository Sections
team_unit_helper = The following access control policy has no effect on the public repositories in this organization.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's "has no effect". Although I can't set up a team with No Access for public repositories because "public" means everyone can Read, I can still set up a team with Write to decide who can write the public repositories.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can append some words to the tooltip of No Access: "It has no effect for public repositories."
image

team_unit_disabled = (Disabled)

form.name_reserved = The organization name '%s' is reserved.
Expand Down
1 change: 1 addition & 0 deletions options/locale/locale_ja-JP.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2338,6 +2338,7 @@ team_desc_helper=チームの目的や役割を説明します。
team_access_desc=リポジトリアクセス
team_permission_desc=権限
team_unit_desc=リポジトリのセクションへのアクセスを許可
team_unit_helper=以下のアクセス制御ポリシーは公開リポジトリに対して効果しないです。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to update this file. It's generated from locale_en-US.ini on https://crowdin.com/project/gitea.

team_unit_disabled=(無効)

form.name_reserved=組織名 '%s' は予約されています。
Expand Down
1 change: 1 addition & 0 deletions options/locale/locale_zh-CN.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,6 +2340,7 @@ team_desc_helper=描述团队的目的或作用。
team_access_desc=仓库权限
team_permission_desc=权限
team_unit_desc=允许访问仓库单元
team_unit_helper=下列访问控制策略对该组织中的公开库无效
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

team_unit_disabled=(已禁用)

form.name_reserved=组织名称 '%s' 是被保留的。
Expand Down
1 change: 1 addition & 0 deletions templates/org/team/new.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@

<div class="team-units required grouped field"{{if eq .Team.AccessMode 3}} style="display: none"{{end}}>
<label>{{.locale.Tr "org.team_unit_desc"}}</label>
<span class="help">{{.locale.Tr "org.team_unit_helper"}}</span>
<table class="ui celled table">
<thead>
<tr>
Expand Down