GitHub API Compliance Fixes #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
tboerger
added
the
lgtm/need 1
|
LGTM. |
tboerger
added
the
lgtm/done
bkcsoft
removed
the
lgtm/need 1
tboerger
added
the
lgtm/done
|
@bkcsoft would it not be technically a 4th and 5th opinion? 1st being yours, 2nd being @0xBAADF00D and 3rd being me... unless I'm not an opinion ._. |
tboerger
added
the
lgtm/done
|
@LefsFlarey I didn't count myself 😆 |
tboerger
added
the
lgtm/done
|
@bkcsoft oh ok. .-. |
tboerger
added
the
lgtm/done
lunny
requested changes
Nov 24, 2016
| @@ -244,6 +244,20 @@ func Get(ctx *context.APIContext) { | |||
| ctx.JSON(200, repo.APIFormat(&api.Permission{true, true, true})) | |||
| } | |||
|
|
|||
| func GetByID(ctx *context.APIContext) { | |||
| repo, err := models.GetRepositoryByID(ctx.ParamsInt64(":id")) | |||
Current coverage is 3.02% (diff: 0.00%)@@ master #227 diff @@
========================================
Files 33 33
Lines 8106 8120 +14
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 246 246
- Misses 7840 7854 +14
Partials 20 20
|
|
@lunny done :) |
bkcsoft
force-pushed
the
api/github-compliance
branch
from
b6ff427
to
b17506c
Compare
|
rebased and fixed conflicts :) |
|
@lunny could you review again? 🙂 |
|
LGTM |
|
But maybe you need to rebase as the drone push failed with matrix builds. |
lunny
approved these changes
Nov 29, 2016
|
push failed |
bkcsoft
force-pushed
the
api/github-compliance
branch
from
b17506c
to
e6cfccd
Compare
bkcsoft
force-pushed
the
api/github-compliance
branch
from
682cd9a
to
e8e0539
Compare
|
Now it should be fine :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few API-bugs
Fixes!
?access_token=[...]?state=allto fetch all issues (for said repo)/repositories/:id(undocumented feature, but it's used by OctoKit 😒 )Backwards Compatability Breakage!
label.Coloris no longer prefixed with#(since GH doesn't do that)Related Issue: #64
I'm sure there are more Gogs-issues that I'm closing with this PR, but I'm to lazy ATM to look them up 😆