Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change org_type.go to visible_type.go and fix the notes #22752

Merged
merged 3 commits into from
Feb 9, 2023
Merged

change org_type.go to visible_type.go and fix the notes #22752

merged 3 commits into from
Feb 9, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Feb 4, 2023

It seems VisibleType is only designed for org at first. But it is also used by user's visibility now.
So I think org_type.go can be changed to visible_type.go.

@lunny lunny added this to the 1.19.0 milestone Feb 4, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 4, 2023
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Feb 8, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2023
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 8, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 8, 2023
@zeripath
Copy link
Contributor

zeripath commented Feb 9, 2023

Make lgtm work

@zeripath zeripath merged commit 7ae10cb into go-gitea:main Feb 9, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 9, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 9, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
563b414 
* upstream/main:
  change org_type.go to visible_type.go and fix the notes (go-gitea#22752)
  Improve notification and stopwatch styles (go-gitea#22169)
  Fix blame view missing lines (go-gitea#22826)
  Load issue before accessing index in merge message (go-gitea#22822)
  include build info in Prometheus metrics (go-gitea#22819)
  Fix rerun button of Actions (go-gitea#22798)
  Map OIDC groups to Orgs/Teams (go-gitea#21441)
  Fix links for the menus in the view file page (go-gitea#22795)
@yp05327 yp05327 deleted the change-visibletype-to-global branch February 21, 2023 02:43
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yp05327 @zeripath @lunny @techknowlogick @GiteaBot