-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add invlid value check to DISABLED_REPO_UNITS and fix incorrect slice combine #23024
Add invlid value check to DISABLED_REPO_UNITS and fix incorrect slice combine #23024
Conversation
I don't know whether it is the best way to fix slice combine error in d038707.
|
4785964
to
d038707
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23024 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 1139 1140 +1
Lines 150707 150790 +83
=======================================
+ Hits 71491 71532 +41
- Misses 70755 70788 +33
- Partials 8461 8470 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I guess there is a related PR |
If user set incorrect vaule to DISABLED_REPO_UNITS, all invaild items in
DisabledRepoUnits
will beUnknown Type 0
, and there's no process to check the invaild value in this function.After: