Fix the show/hide methods for string selector #23042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Feb 21, 2023
GiteaBot
added
the
lgtm/need 1
lunny
added
type/bug
skip-changelog
wolfogre
approved these changes
Feb 21, 2023
GiteaBot
added
lgtm/done
delvh
approved these changes
Feb 21, 2023
delvh
added
the
reviewed/wait-merge
|
🎺 🤖 |
jolheiser
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 22, 2023
* upstream/main: Changelog 1.18.5 (go-gitea#23045) (go-gitea#23049) Add Bash and Zsh completion scripts (go-gitea#22646) Return empty url for submodule tree entries (go-gitea#23043) Fix the show/hide methods for string selector (go-gitea#23042) display attachments of review comment when comment content is blank (go-gitea#23035) Upgrade to stylelint 15 (go-gitea#22944) Add force_merge to merge request and fix checking mergable (go-gitea#23010) Improve PR Review Box UI (go-gitea#22986) Remove dashes between organization member avatars on hover (go-gitea#23034) Fix the Manually Merged form (go-gitea#23015) Remove delete button for review comment (go-gitea#23036) Improve frontend guidelines (go-gitea#23007) Use `--message=%s` for git commit message (go-gitea#23028)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At that moment I made a mistake (failed to detect a JS variable type correctly)
Close #23040
Screenshot for the fix: