Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix db.Find bug #23115

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Fix db.Find bug #23115

merged 3 commits into from
Feb 24, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 24, 2023

Caused by #20821

Fix #23110

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Feb 24, 2023
@lunny lunny added this to the 1.20.0 milestone Feb 24, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 24, 2023
@KN4CK3R
Copy link
Member

KN4CK3R commented Feb 24, 2023

CI fail is related.

@lunny lunny merged commit a8c4f8c into go-gitea:main Feb 24, 2023
@lunny lunny deleted the lunny/fix_db_find_bug branch February 24, 2023 13:17
@yardenshoham yardenshoham mentioned this pull request Feb 24, 2023
Merged
yardenshoham pushed a commit to yardenshoham/gitea that referenced this pull request Feb 24, 2023
@lunny @yardenshoham
Fix db.Find bug (go-gitea#23115)
635b67f 
Caused by go-gitea#20821 

Fix go-gitea#23110
@yardenshoham yardenshoham added the backport/done All backports for this PR have been created label Feb 24, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 24, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
02f7298 
* giteaoffical/main:
  Fix db.Find bug (go-gitea#23115)
  Avoid warning for system setting when start up (go-gitea#23054)
  Require approval to run actions for fork pull request (go-gitea#22803)
  Fix nil context in RenderMarkdownToHtml (go-gitea#23092)
  Add HesterG to maintainers (go-gitea#23104)
  improve FindProjects (go-gitea#23085)
zeripath pushed a commit that referenced this pull request Feb 24, 2023
@yardenshoham
Fix db.Find bug (#23115) (#23119)
27e3071 
Backport #23115

Caused by #20821 

Fix #23110
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

[E] PullRequestList.InvalidateCodeComments: find code comments: needs a pointer to a slice or a map
6 participants
@lunny @KN4CK3R @wolfogre @delvh @yardenshoham @GiteaBot