Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper to author to avoid long name ui problem (#23030) #23172

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Feb 27, 2023

Backport #23030

This PR is a possible solution for issue #22866. Main change is to add a author-wrapper class around author name, like the wrapper added to message. The max-width is set to 200px on PC, and 100px on mobile device for now. Which will work like below:

截屏2023-02-21 11 57 53

截屏2023-02-21 11 58 43

And title is added to the wrapper like it did in message wrapper. So the full author name will show on hover.

…is to add a

`author-wrapper` class around author name, like the wrapper added to
message. The `max-width` is set to 200px on PC, and 100px on mobile
device for now.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 27, 2023
@yardenshoham yardenshoham added this to the 1.18.6 milestone Feb 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2023
@lunny lunny merged commit 5a60e02 into go-gitea:release/v1.18 Feb 27, 2023
@HesterG HesterG deleted the backport-PR-23030 branch March 1, 2023 06:27
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants