Fix cannot reopen after pushing commits to a closed PR

[sillyguodong]

Close: #22784

1. On GH, we can reopen a PR which was closed before after pushing commits. After reopening PR, we can see the commits that were pushed after closing PR in the time line. So the case of issue is a bug which needs to be fixed.

2. After closing a PR and pushing commits, headBranchSha is not equal to sha(which is the last commit ID string of reference). If the judgement exists, the button of reopen will not display. So, skip the judgement if the status of PR is closed.
   

3. Even if PR is already close, we should still insert comment record into DB when we push commits.
   So we should still call function CreatePushPullComment().
   

   gitea/services/pull/pull.go

   Lines 260 to 282 in 067b0c2

   	prs, err := issues_model.GetUnmergedPullRequestsByHeadInfo(repoID, branch)
   	if err != nil {
   	log.Error("Find pull requests [head_repo_id: %d, head_branch: %s]: %v", repoID, branch, err)
   	return
   	}
   	for _, pr := range prs {
   	log.Trace("Updating PR[%d]: composing new test task", pr.ID)
   	if pr.Flow == issues_model.PullRequestFlowGithub {
   	if err := PushToBaseRepo(ctx, pr); err != nil {
   	log.Error("PushToBaseRepo: %v", err)
   	continue
   	}
   	} else {
   	continue
   	}
   	AddToTaskQueue(pr)
   	comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
   	if err == nil && comment != nil {
   	notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
   	}
   	}

   
   So, I add a switch(includeClosed) to the GetUnmergedPullRequestsByHeadInfo func to control whether the status of PR must be open. In this case, by setting includeClosed to true, we can query the closed PR.
   

4. In the loop of comments, I use thelatestCloseCommentID variable to record the last occurrence of the close comment.
   In the go template, if the status of PR is closed, the comments whose type is CommentTypePullRequestPush(29) after latestCloseCommentID won't be rendered.
   
   e.g.
   1). The initial status of the PR is opened.
   
   2). Then I click the button of Close. PR is closed now.
   
   3). I try to push a commit to this PR, even though its current status is closed.
   
   But in comments list, this commit do not display.This is as expected ：）
   
   4). Click the Reopen button, the commit which is pushed after closing PR display now.
   

[brechtvl]

We've run into cases where a PR had a difference in these SHAs and so was shown as broken, even when it had never been closed. But we have not been able to get a clear repro case yet.

Maybe this test can be skipped for closed PRs, but remain for open PRs? If what's shown in the PR and what's in the head branch is not the same, I think it's important to show that to avoid accidentally merging the wrong code.

[sillyguodong]

okey, now skip the test when only the PR is closed

[codecov-commenter]

Codecov Report

Merging #23189 (cf9fea6) into main (33e556e) will increase coverage by 0.13%.
The diff coverage is 53.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23189      +/-   ##
==========================================
+ Coverage   47.44%   47.58%   +0.13%     
==========================================
  Files        1140     1143       +3     
  Lines      150804   151086     +282     
==========================================
+ Hits        71549    71894     +345     
+ Misses      70788    70691      -97     
- Partials     8467     8501      +34     

Impacted Files	Coverage Δ
models/actions/run.go	1.72% <0.00%> (+0.01%)	⬆️
models/actions/run_list.go	0.00% <0.00%> (ø)
models/actions/status.go	22.85% <0.00%> (-1.39%)	⬇️
models/auth/oauth2.go	60.52% <ø> (ø)
models/auth/twofactor.go	19.73% <ø> (ø)
models/db/engine.go	44.80% <ø> (ø)
models/issues/label.go	57.35% <0.00%> (+1.39%)	⬆️
models/unittest/testdb.go	12.92% <0.00%> (ø)
modules/auth/password/hash/pbkdf2.go	69.69% <ø> (ø)
modules/avatar/hash.go	100.00% <ø> (ø)
... and 94 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[wolfogre]

Sorry, approved by accident.