Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill head commit to in payload when notifying push commits for mirroring #23215

Merged
merged 3 commits into from
Mar 4, 2023
Merged

Fill head commit to in payload when notifying push commits for mirroring #23215

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95228b7
fix: fill head commit in payload
wolfogre Mar 1, 2023
7a75d96
Update services/mirror/mirror_pull.go
wolfogre Mar 4, 2023
e9c588e
Merge branch 'main' into bugfix/payload_head_commit
lunny Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions services/mirror/mirror_pull.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,13 @@ func SyncPullMirror(ctx context.Context, repoID int64) bool {
theCommits.Commits = theCommits.Commits[:setting.UI.FeedMaxCommitNum]
}

if newCommit, err := gitRepo.GetCommit(newCommitID); err != nil {
log.Error("SyncMirrors [repo: %-v]: unable to get GetCommit [%s]: %v", m.Repo, newCommitID, err)
wolfogre marked this conversation as resolved.
Show resolved Hide resolved
continue
} else {
theCommits.HeadCommit = repo_module.CommitToPushCommit(newCommit)
}

theCommits.CompareURL = m.Repo.ComposeCompareURL(oldCommitID, newCommitID)

notification.NotifySyncPushCommits(ctx, m.Repo.MustOwner(ctx), m.Repo, &repo_module.PushUpdateOptions{
Expand Down