Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment #23245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
changed the title
wxiaoguang
changed the title
wxiaoguang
force-pushed
the
fix-review-submit
branch
3 times, most recently
from
c93341f to
6feaccc
Compare
wxiaoguang
force-pushed
the
fix-review-submit
branch
from
6feaccc to
9e1f760
Compare
|
I can confirm this works! |
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Mar 3, 2023
GiteaBot
added
lgtm/need 1
lunny
added
the
pr/breaking
delvh
approved these changes
Mar 3, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 6, 2023
* giteaofficial/main: (28 commits) Update hacking-on-gitea-zh_cn documentation (go-gitea#23315) Fix broken code editor diff preview (go-gitea#23307) [skip ci] Updated translations via Crowdin Add context when rendering labels or emojis (go-gitea#23281) Change interactiveBorder to fix popup preview (go-gitea#23169) Improve the frontend guideline (go-gitea#23298) Scoped labels: set aria-disabled on muted Exclusive option for a11y (go-gitea#23306) Add basic documentation for labels, including scoped labels (go-gitea#23304) [skip ci] Updated translations via Crowdin Re-add accidentally removed `hacking-on-gitea.zh-cn.md` (go-gitea#23297) Add default owner team to privated_org and limited_org in unit test (go-gitea#23109) Improve sed detection in update-locales.sh (go-gitea#23254) Support sanitising the URL by removing extra slashes in the URL (go-gitea#21333) Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (go-gitea#23245) Avoid panic caused by broken payload when creating commit status (go-gitea#23216) Add run status in action view page (go-gitea#23212) update to mermaid v10 (go-gitea#23178) Fix code wrap for unbroken lines (go-gitea#23268) Fix stray backticks appearing in pull request timeline (go-gitea#23282) Fill head commit to in payload when notifying push commits for mirroring (go-gitea#23215) ...
This was referenced Mar 31, 2023
lunny
pushed a commit
that referenced
this pull request
Apr 1, 2023
|
@lunny why breaking? |
The behavior of pressing Ctrl+Enter has been changed on this PR. |
|
Hmm… |
lunny
removed
the
pr/breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #23241
Before: press Ctrl+Enter in the Code Review Form, a single comment will be added.
After: press Ctrl+Enter in the Code Review Form, start the review with pending comments.
The old name
is_reviewis not clear, so the new code usepending_reviewas the new name.