Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding of empty class name #23352

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Fix adding of empty class name #23352

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bac1c5
fix adding of empty class name
HesterG Mar 7, 2023
31a4a94
fix lint
HesterG Mar 7, 2023
0088b06
Merge branch 'main' into fix-empty-class
lunny Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web_src/js/svg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ export function svg(name, size = 16, className = '') {
const svgNode = document.firstChild;
if (size !== 16) svgNode.setAttribute('width', String(size));
if (size !== 16) svgNode.setAttribute('height', String(size));
if (className) svgNode.classList.add(...className.split(/\s+/));
// filter array to remove empty string
if (className) svgNode.classList.add(...className.split(/\s+/).filter(item => item));
return serializer.serializeToString(svgNode);
}

Expand Down