-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dashboard repo list to Vue SFC #23405
Refactor dashboard repo list to Vue SFC #23405
Conversation
4bb9816
to
d3adc0d
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23405 +/- ##
=======================================
Coverage ? 47.13%
=======================================
Files ? 1147
Lines ? 151255
Branches ? 0
=======================================
Hits ? 71296
Misses ? 71527
Partials ? 8432 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Similar to #23394
The dashboard repo list mixes jQuery/Fomantic UI/Vue together, it's very diffcult to maintain and causes unfixable a11y problems.
This PR uses two steps to refactor the repo list:
data-
attributes to JS object and use Vue data as much as possible d3adc0dTotal: +516 −585
Screenshots: