Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dashboard repo list to Vue SFC #23405

Merged
merged 11 commits into from
Mar 14, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 10, 2023

Similar to #23394

The dashboard repo list mixes jQuery/Fomantic UI/Vue together, it's very diffcult to maintain and causes unfixable a11y problems.

This PR uses two steps to refactor the repo list:

  1. move data- attributes to JS object and use Vue data as much as possible d3adc0d
  2. move the code into a Vue SFC 7ebe55d

Total: +516 −585

Screenshots:

image

image

image

@wxiaoguang wxiaoguang force-pushed the refactor-dashboard-repo-list branch from 4bb9816 to d3adc0d Compare March 10, 2023 08:58
@wxiaoguang wxiaoguang changed the title Refactor dashboard repo list (first step) Refactor dashboard repo list to Vue SFC Mar 10, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 10, 2023
web_src/js/svg.js Outdated Show resolved Hide resolved
web_src/js/svg.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@dad057b). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8c5299b differs from pull request most recent head e660dff. Consider uploading reports for the commit e660dff to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main   #23405   +/-   ##
=======================================
  Coverage        ?   47.13%           
=======================================
  Files           ?     1147           
  Lines           ?   151255           
  Branches        ?        0           
=======================================
  Hits            ?    71296           
  Misses          ?    71527           
  Partials        ?     8432           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@techknowlogick techknowlogick added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 10, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Mar 10, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 13, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 13, 2023
@lunny lunny merged commit e82f1b1 into go-gitea:main Mar 14, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2023
@wxiaoguang wxiaoguang deleted the refactor-dashboard-repo-list branch March 14, 2023 04:47
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants