Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missed migration in #22235 #23482

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Fix missed migration in #22235 #23482

merged 4 commits into from
Mar 15, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 15, 2023

No description provided.

@lunny lunny added the type/bug label Mar 15, 2023
@lunny lunny added this to the 1.20.0 milestone Mar 15, 2023
@yp05327 yp05327 mentioned this pull request Mar 15, 2023
Merged
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #23482 (18282ab) into main (f521e88) will increase coverage by 0.01%.
The diff coverage is 42.21%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23482      +/-   ##
==========================================
+ Coverage   47.14%   47.16%   +0.01%     
==========================================
  Files        1149     1154       +5     
  Lines      151446   152178     +732     
==========================================
+ Hits        71397    71769     +372     
- Misses      71611    71938     +327     
- Partials     8438     8471      +33
Impacted Files Coverage Δ
cmd/dump.go 0.67% <0.00%> (ø)
models/actions/run.go 1.64% <0.00%> (-0.08%) ⬇️
models/packages/package.go 45.45% <0.00%> (-1.13%) ⬇️
modules/actions/github.go 0.00% <0.00%> (ø)
modules/actions/workflows.go 0.00% <0.00%> (ø)
modules/doctor/storage.go 31.93% <0.00%> (ø)
modules/setting/git.go 45.45% <ø> (ø)
modules/storage/minio.go 1.51% <0.00%> (-0.06%) ⬇️
modules/structs/user.go 100.00% <ø> (ø)
routers/api/v1/admin/email.go 0.00% <0.00%> (ø)
... and 33 more

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 15, 2023
wolfogre
wolfogre approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@wolfogre wolfogre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my fault too. So surprised that I didn't find it when I reviewed it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 15, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 15, 2023
@KN4CK3R KN4CK3R merged commit 27494ed into go-gitea:main Mar 15, 2023
@yardenshoham
Copy link
Member

How does this affect v1.19.0?

@lunny lunny deleted the lunny/fix_missed_migration branch March 15, 2023 10:11
@lunny
Copy link
Member Author

lunny commented Mar 15, 2023

Have no idea. Since Sync also do the same work. So people may not find the problem if they don't run tests.
Maybe we can have a doctor command to check all the database schema inconsistent problems and fix that?

@yardenshoham
Copy link
Member

Is it possible to backport a migration?

@lunny
Copy link
Member Author

lunny commented Mar 15, 2023

Is it possible to backport a migration?

Not yet.

@delvh
Copy link
Member

delvh commented Mar 15, 2023

Not a good idea.

@yardenshoham
Copy link
Member

Will projects work in v1.19?

@lunny
Copy link
Member Author

lunny commented Mar 15, 2023

Will projects work in v1.19?

I think yes except some bugs.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 15, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
710f67c 
* giteaoffical/main:
  Add login name and source id for admin user searching API (go-gitea#23376)
  Fix missed migration in go-gitea#22235 (go-gitea#23482)
  Disable sending email after push a commit to a closed PR (go-gitea#23462)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lunny @codecov-commenter @yardenshoham @delvh @KN4CK3R @wolfogre @GiteaBot @techknowlogick