Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS dependencies, Require Node.js 16 #23528

Merged
merged 6 commits into from
Mar 17, 2023
Merged

Update JS dependencies, Require Node.js 16 #23528

merged 6 commits into from
Mar 17, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 16, 2023 •
edited
Loading

  • Update all JS dependencies
  • Require Node.js 16 as dictated by esbuild-loader
  • Regenerate SVG
  • Adapt to esbuild-loader breaking changes
  • Minor refactor in webpack.config.js
  • Tested build, monaco and swagger-ui

@silverwind silverwind added this to the 1.20.0 milestone Mar 16, 2023
@silverwind
Copy link
Member Author

esbuild-loader seems to require Node 16, so I will bump our minimum version as well with this.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 16, 2023
@silverwind silverwind changed the title Update JS dependencies Update JS dependencies, Require Node.js 16 Mar 16, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2023
@silverwind
Copy link
Member Author

#22269 already did the node bump to 16 in docs apparently, so this syncs the change to package.json as well now.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 16, 2023
@wxiaoguang wxiaoguang mentioned this pull request Mar 17, 2023
Merged
@techknowlogick techknowlogick enabled auto-merge (squash) March 17, 2023 03:56
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit 96be0cb into go-gitea:main Mar 17, 2023
@techknowlogick techknowlogick removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 17, 2023
@silverwind silverwind deleted the deps-47 branch March 17, 2023 09:34
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @techknowlogick @lafriks @delvh @GiteaBot