Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add self to maintainers #23644

Merged
merged 3 commits into from
May 24, 2023
Merged

Add self to maintainers #23644

merged 3 commits into from
May 24, 2023

Conversation

philip-peterson
Copy link
Contributor

Hi all,

I've very much enjoyed working on Gitea and was hoping to make it official by requesting maintainership. :) Excited to see what the future holds for this project.

My merged PRs list

Cheers,
Phil

Hi all,

I've very much enjoyed working on Gitea and was hoping to make it official by requesting maintainership. :) Excited to see what the future holds for this project.

My [merged PRs list](https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3Aphilip-peterson+is%3Amerged+)

Cheers,
Phil
@wolfogre
Copy link
Member

wolfogre commented Mar 23, 2023

Thanks and welcome!

But I think there are two more things you should do before becoming a maintainer:

  • Read the CONTRIBUTING
  • image (😁I am sure you will get it when you read the CONTRIBUTING)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 23, 2023
@philip-peterson
Copy link
Contributor Author

👍 sounds good, wasn't sure what the cutoff was. Maybe this PR can be closed until later?

@jolheiser
Copy link
Member

More than happy to leave it open if you'd like, and thanks for the great work you've done thus far!

@philip-peterson
Copy link
Contributor Author

Got my fourth today! https://github.com/go-gitea/gitea/pulls?q=is%3Apr+author%3Aphilip-peterson+is%3Amerged+

Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooo!

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 24, 2023
@GiteaBot
Copy link
Contributor

@philip-peterson please fix the merge conflicts. 🍵

@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 24, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2023
MAINTAINERS Outdated Show resolved Hide resolved
@jolheiser jolheiser added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 24, 2023
@lunny lunny merged commit 69e73fd into go-gitea:main May 24, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone May 24, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 24, 2023
@philip-peterson
Copy link
Contributor Author

Thank you all! Excited to join the team 😄

@techknowlogick
Copy link
Member

@philip-peterson do you have a discord account that I can add you to the server?

@philip-peterson
Copy link
Contributor Author

@techknowlogick Yes, it's philip#6132 , just sent you a message

zjjhot added a commit to zjjhot/gitea that referenced this pull request May 25, 2023
* upstream/main: (21 commits)
  `zh-cn` translation for usage docs (go-gitea#24897)
  Add chinese documentations for installation (go-gitea#24904)
  Improve RunMode / dev mode (go-gitea#24886)
  Add chinese documentations for `Packages` (go-gitea#24914)
  Rework notifications list (go-gitea#24812)
  New webhook trigger for receiving Pull Request review requests (go-gitea#24481)
  Use file filters action instead of Github's files filter (go-gitea#24877)
  Update Asciidoc markup example with safe defaults (go-gitea#24920)
  Add self to maintainers (go-gitea#23644)
  Create pull request for base after editing file, if not enabled on fork (go-gitea#24841)
  Reduce verbosity of dev commands (go-gitea#24917)
  Merge different languages for language stats (go-gitea#24900)
  Add missing test case and fix typo in tests (go-gitea#24915)
  Improve confusable character string (go-gitea#24911)
  Improve Actions CSS (go-gitea#24864)
  Fix <empty> in administration/config-cheat-sheet.en-us.md (go-gitea#24905)
  Only validate changed columns when update user (go-gitea#24867)
  Rename docs packages title from xxx Packages Repository -> xxx Package Registry (go-gitea#24895)
  Fix can’t move anymore items in repo project boards (go-gitea#24892)
  Make environment-to-ini  support loading key value from file (go-gitea#24832)
  ...

# Conflicts:
#	web_src/css/helpers.css
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants