Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions compatible globbing for branches, tag, path filter (#22804) #23740

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #22804 by @ChristopherHX

Replaces the current globbing library with a https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet compatible one.

This adds support for

  • paths-ignore, tags-ignore and branches-ignore filters.
  • negative patterns in paths, tags and branches filters
  • using both tags and paths filter on the push event

Original PR https://gitea.com/gitea/act/pulls/13.
nektos/act PR nektos/act#1618 for the workflowpattern package (It can take some months for it to appear in https://gitea.com/gitea/act)

Related to #13539

…filter (go-gitea#22804)

Replaces the current globbing library with a
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
compatible one.

This adds support for
- `paths-ignore`, `tags-ignore` and `branches-ignore` filters.
- negative patterns in `paths`, `tags` and `branches` filters
- using both `tags` and `paths` filter on the push event

Original PR https://gitea.com/gitea/act/pulls/13.
nektos/act PR nektos/act#1618 for the
workflowpattern package (It can take some months for it to appear in
https://gitea.com/gitea/act)

Related to go-gitea#13539
@GiteaBot GiteaBot added the type/enhancement An improvement of existing functionality label Mar 27, 2023
@GiteaBot GiteaBot added this to the 1.19.1 milestone Mar 27, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 27, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 27, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 27, 2023 17:28
@techknowlogick
Copy link
Member

ping lg-tm

@techknowlogick techknowlogick merged commit 35039b8 into go-gitea:release/v1.19 Mar 27, 2023
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@techknowlogick techknowlogick deleted the backport-22804-v1.19 branch September 9, 2023 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants