Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS rules for basic colored labels #23774

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Add CSS rules for basic colored labels #23774

merged 3 commits into from
Mar 29, 2023

Conversation

silverwind
Copy link
Member

Before:

Screenshot 2023-03-28 at 23 35 46

After:
Screenshot 2023-03-28 at 23 35 54

Also I removed the !important on the primary label as it's very likely unnecessary with the amount of specificity the selector already has.

@silverwind silverwind added the type/enhancement An improvement of existing functionality label Mar 28, 2023
@silverwind silverwind added this to the 1.20.0 milestone Mar 28, 2023
@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Mar 28, 2023
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 28, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2023
@silverwind silverwind added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 28, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) March 29, 2023 01:15
@techknowlogick techknowlogick merged commit 79e7a6e into go-gitea:main Mar 29, 2023
@GiteaBot GiteaBot mentioned this pull request Mar 29, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 29, 2023
@silverwind @GiteaBot
Add CSS rules for basic colored labels (go-gitea#23774)
cf63041 
Before:

<img width="164" alt="Screenshot 2023-03-28 at 23 35 46"
src="https://user-images.githubusercontent.com/115237/228372437-663111b9-7285-4fa2-9125-fb5e1cad21d7.png">

After:
<img width="166" alt="Screenshot 2023-03-28 at 23 35 54"
src="https://user-images.githubusercontent.com/115237/228372441-49430517-6b2d-4389-b11c-c30a724f6de7.png">

Also I removed the `!important` on the primary label as it's very likely
unnecessary with the amount of specificity the selector already has.
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Mar 29, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 29, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
58ed503 
* upstream/main:
  Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (go-gitea#23687)
  Add CSS rules for basic colored labels (go-gitea#23774)
  Add meilisearch support (go-gitea#23136)
  Add missing translation for `actions.runners.reset_registration_token_success` (go-gitea#23732)
  [skip ci] Updated translations via Crowdin
  Implement Issue Config (go-gitea#20956)
  Set repository link based on the url in package.json for npm packages (go-gitea#20379)
  Add API to manage issue dependencies (go-gitea#17935)
  Add creation time in tag list page (go-gitea#23693)
  Make minio package support legacy MD5 checksum (go-gitea#23768)
  Yarden Shoham has a new email address (go-gitea#23767)
  fix br display for packages curls (go-gitea#23737)
jolheiser pushed a commit that referenced this pull request Mar 29, 2023
@GiteaBot @silverwind
Add CSS rules for basic colored labels (#23774) (#23777)
d27e693 
Backport #23774 by @silverwind

Before:

<img width="164" alt="Screenshot 2023-03-28 at 23 35 46"
src="https://user-images.githubusercontent.com/115237/228372437-663111b9-7285-4fa2-9125-fb5e1cad21d7.png">

After:
<img width="166" alt="Screenshot 2023-03-28 at 23 35 54"
src="https://user-images.githubusercontent.com/115237/228372441-49430517-6b2d-4389-b11c-c30a724f6de7.png">

Also I removed the `!important` on the primary label as it's very likely
unnecessary with the amount of specificity the selector already has.

Co-authored-by: silverwind <me@silverwind.io>
@HesterG HesterG mentioned this pull request Apr 4, 2023
Merged
@silverwind silverwind deleted the basic-labels branch April 9, 2023 09:49
silverwind pushed a commit that referenced this pull request Apr 9, 2023
@HesterG @delvh @lunny
Show protected branch rule names again (#23907)
a519aac 
`!important`s for one of the primary label selectors are removed by
#23774, so the repository branch protection settings ui will not have
the demanding css. This PR modifies `.ui.primary.label` to fix it.

Before:
<img width="1408" alt="飞书20230404-115410"
src="https://user-images.githubusercontent.com/17645053/229683221-ef9c7d5c-68a8-42b0-ba19-ef2d5dfce5f9.png">

After:
<img width="1419" alt="截屏2023-04-04 11 56 32"
src="https://user-images.githubusercontent.com/17645053/229683469-70cfc92d-d7ef-4323-a7f5-2247810fabce.png">

---------

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@GiteaBot GiteaBot mentioned this pull request Apr 9, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 9, 2023
@HesterG @delvh @lunny
Show protected branch rule names again (go-gitea#23907)
9430527 
`!important`s for one of the primary label selectors are removed by
go-gitea#23774, so the repository branch protection settings ui will not have
the demanding css. This PR modifies `.ui.primary.label` to fix it.

Before:
<img width="1408" alt="飞书20230404-115410"
src="https://user-images.githubusercontent.com/17645053/229683221-ef9c7d5c-68a8-42b0-ba19-ef2d5dfce5f9.png">

After:
<img width="1419" alt="截屏2023-04-04 11 56 32"
src="https://user-images.githubusercontent.com/17645053/229683469-70cfc92d-d7ef-4323-a7f5-2247810fabce.png">

---------

Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind pushed a commit that referenced this pull request Apr 9, 2023
@GiteaBot @HesterG
@delvh @lunny
Show protected branch rule names again (#23907) (#24018)
695738f 
Backport #23907 by @HesterG

`!important`s for one of the primary label selectors are removed by
#23774, so the repository branch protection settings ui will not have
the demanding css. This PR modifies `.ui.primary.label` to fix it.

Before:
<img width="1408" alt="飞书20230404-115410"
src="https://user-images.githubusercontent.com/17645053/229683221-ef9c7d5c-68a8-42b0-ba19-ef2d5dfce5f9.png">

After:
<img width="1419" alt="截屏2023-04-04 11 56 32"
src="https://user-images.githubusercontent.com/17645053/229683469-70cfc92d-d7ef-4323-a7f5-2247810fabce.png">

Co-authored-by: Hester Gong <hestergong@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @jolheiser @delvh @techknowlogick @GiteaBot