Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons #23819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
improve-locales
branch
5 times, most recently
from
6499f43
to
af0cc36
Compare
wxiaoguang
force-pushed
the
improve-locales
branch
from
af0cc36
to
538bf8e
Compare
wxiaoguang
changed the title
lunny
approved these changes
Mar 30, 2023
GiteaBot
added
the
lgtm/need 1
wolfogre
approved these changes
Mar 31, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
lunny
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2023
* giteaoffical/main: Fix 500 error if there is a name conflict when edit authentication source (go-gitea#23832) Use different SVG for pending and running actions (go-gitea#23836) CSS color tweaks (go-gitea#23828) Clarify Gitea/Crowdin locale behaviors, add tests for LocaleStore, fix some strings with semicolons (go-gitea#23819)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #23633 and #23240
Close #23814
Now we almost have a complete test set for Gitea's LocalStore.
This PR is still a quick fix for the legacy locale system (see the TODOs), to resolve the problems fundamentally, it needs more work in the future.