Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Use default branch as ref when a branch/tag delete occurs #23910

Merged
merged 4 commits into from
Apr 7, 2023
Merged

Actions: Use default branch as ref when a branch/tag delete occurs #23910

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98a539b
Use default branch as ref when a delete occurs
bnabholz Apr 3, 2023
52dacf0
Update services/actions/notifier_helper.go
wolfogre Apr 6, 2023
53aead1
Merge branch 'main' into fix/delete-action
jolheiser Apr 6, 2023
fe91485
Merge branch 'main' into fix/delete-action
lunny Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions services/actions/notifier_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ func notify(ctx context.Context, input *notifyInput) error {
defer gitRepo.Close()

ref := input.Ref
if input.Event == webhook_module.HookEventDelete {
// The event is deleting a reference, so it will fail to get the commit for a deleted reference.
// Set ref to empty string to fall back to the default branch.
ref = ""
}
if ref == "" {
ref = input.Repo.DefaultBranch
}
Expand Down