Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: make the required backticks in email password more explicit #23923

Merged
merged 2 commits into from
Apr 4, 2023
Merged

docs: make the required backticks in email password more explicit #23923

merged 2 commits into from
Apr 4, 2023

Conversation

teauxfu
Copy link
Contributor

@teauxfu teauxfu commented Apr 4, 2023

updated the example config to make the needed backticks around the password more obvious

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 4, 2023
@techknowlogick techknowlogick added this to the 1.20.0 milestone Apr 4, 2023
techknowlogick
techknowlogick approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, and other docs PRs :)

The backticks are optional, but I agree it's probably a good idea to include them in case a user has certain special characters in their password that ini doesn't like

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 4, 2023 17:17
@techknowlogick
Copy link
Member

🤖 🎺

@techknowlogick techknowlogick merged commit 0983b23 into go-gitea:main Apr 4, 2023
@GiteaBot GiteaBot mentioned this pull request Apr 4, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Apr 4, 2023
@teauxfu
docs: make the required backticks in email password more explicit (go…
ea10f6b 
…-gitea#23923)

updated the example config to make the needed backticks around the
password more obvious
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 4, 2023
techknowlogick pushed a commit that referenced this pull request Apr 4, 2023
@GiteaBot @teauxfu
docs: make the required backticks in email password more explicit (#2…
8d88f14 
…3923) (#23926)

Backport #23923 by @teauxfu

updated the example config to make the needed backticks around the
password more obvious

Co-authored-by: alex <alexmw777@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 5, 2023
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
69573be 
* giteaoffical/main:
  Fix image border-radius (go-gitea#23886)
  [skip ci] Updated translations via Crowdin
  Scroll collapsed file into view (go-gitea#23702)
  docs: make the required backticks in email password more explicit (go-gitea#23923)
  docs: fix typo (go-gitea#23924)
  Update docs markdown file weight to make it clear (go-gitea#23909)
  Add activity feeds API (go-gitea#23494)
  Fix code view (diff) broken layout (go-gitea#23096)
  Use ghost user if package creator does not exist (go-gitea#23822)
  Org pages style fixes (go-gitea#23901)
  User/Org Feed render description as per web (go-gitea#23887)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/backport/v1.19 This PR should be backported to Gitea 1.19 type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
4 participants
@teauxfu @techknowlogick @delvh @GiteaBot