Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash when parsing an invalid workflow file #23972

Merged
merged 5 commits into from
Apr 7, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix comments
wolfogre committed Apr 7, 2023

Verified

This commit was signed with the committer’s verified signature.
wolfogre Jason Song
commit b2ae41c8400358ab35ff5da47a04c4cf68342034
4 changes: 2 additions & 2 deletions modules/actions/workflows.go
Original file line number Diff line number Diff line change
@@ -23,8 +23,8 @@ import (
func init() {
model.OnDecodeNodeError = func(node yaml.Node, out interface{}, err error) {
// Log the error instead of panic or fatal.
// It will be a big job to refactor act/pkg/model return decode error,
// so we just log the error and continue, and improve it later.
// It will be a big job to refactor act/pkg/model to return decode error,
// so we just log the error and return empty value, and improve it later.
log.Error("Failed to decode node %v into %T: %v", node, out, err)
}
}