Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder and aria attributes to release and wiki edit page #24031

Merged
merged 10 commits into from
Apr 10, 2023
+26 −18
Merged

Add placeholder and aria attributes to release and wiki edit page #24031

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
31f8923
Add placeholder attributes to release and wiki edit page
silverwind Apr 10, 2023
68284b7
make release page more compact
silverwind Apr 10, 2023
42af540
add quotes
silverwind Apr 10, 2023
2f7d937
remove unused locale string
silverwind Apr 10, 2023
5c39904
add aria-label
silverwind Apr 10, 2023
bb2532b
more aria-label
silverwind Apr 10, 2023
2bf911c
revert air change
silverwind Apr 10, 2023
06de744
update template docs
silverwind Apr 10, 2023
f3bd81d
remove title cases
silverwind Apr 10, 2023
ea0d15d
Merge branch 'main' into placeholders
jolheiser Apr 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make release page more compact
@silverwind
silverwind committed Apr 10, 2023
commit 68284b7dd62312d38a25a4b352991aa995a33f1b
7 changes: 2 additions & 5 deletions templates/repo/release/new.tmpl
View file
Original file line number Diff line number Diff line change
@@ -39,19 +39,16 @@
</div>
</div>
<div>
<span id="tag-helper" class="help gt-mt-2">{{.locale.Tr "repo.release.tag_helper"}}</span>
<span id="tag-helper" class="help gt-mt-3 gt-pb-0">{{.locale.Tr "repo.release.tag_helper"}}</span>
</div>
{{end}}
</div>
</div>
<div class="eleven wide column">
<div class="eleven wide column gt-pt-0">
<div class="field {{if .Err_Title}}error{{end}}">
<label>{{.locale.Tr "repo.release.title"}}</label>
<input name="title" placeholder="{{.locale.Tr "repo.release.title"}}" value="{{.title}}" autofocus maxlength="255">
</div>
<div class="field">
<label>{{.locale.Tr "repo.release.content"}}</label>

{{template "shared/combomarkdowneditor" (dict
"locale" $.locale
"MarkdownPreviewUrl" (print .Repository.Link "/markup")