-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show friendly 500 error page to users and developers #24110
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26cdf56
to
1b16fc0
Compare
1b16fc0
to
0338d5f
Compare
silverwind
reviewed
Apr 13, 2023
silverwind
approved these changes
Apr 13, 2023
Tested and the issue is fixed, so LGTM |
Codecov Report
@@ Coverage Diff @@
## main #24110 +/- ##
==========================================
- Coverage 47.14% 47.10% -0.04%
==========================================
Files 1149 1161 +12
Lines 151446 153766 +2320
==========================================
+ Hits 71397 72433 +1036
- Misses 71611 72812 +1201
- Partials 8438 8521 +83
... and 153 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2023
* upstream/main: Show friendly 500 error page to users and developers (go-gitea#24110)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #24104
This also introduces many tests to cover many complex error handling functions.
Before
The details are never shown in production.
After
The details could be shown to site admin users. It is safe.