Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show friendly 500 error page to users and developers #24110

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 13, 2023

Close #24104

This also introduces many tests to cover many complex error handling functions.

Before

The details are never shown in production.

image

After

The details could be shown to site admin users. It is safe.

image

@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 13, 2023
@wxiaoguang wxiaoguang force-pushed the improve-500-page branch 3 times, most recently from 26cdf56 to 1b16fc0 Compare April 13, 2023 16:09
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2023
@HesterG
Copy link
Contributor

HesterG commented Apr 14, 2023

Tested and the issue is fixed, so LGTM

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 14, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Merging #24110 (14c8422) into main (f521e88) will decrease coverage by 0.04%.
The diff coverage is 41.65%.

@@            Coverage Diff             @@
##             main   #24110      +/-   ##
==========================================
- Coverage   47.14%   47.10%   -0.04%     
==========================================
  Files        1149     1161      +12     
  Lines      151446   153766    +2320     
==========================================
+ Hits        71397    72433    +1036     
- Misses      71611    72812    +1201     
- Partials     8438     8521      +83     
Impacted Files Coverage Δ
cmd/dump.go 0.64% <0.00%> (-0.03%) ⬇️
cmd/embedded.go 0.00% <0.00%> (ø)
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
... and 61 more

... and 153 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lunny lunny merged commit 1c8bc40 into go-gitea:main Apr 14, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 14, 2023
@wxiaoguang wxiaoguang deleted the improve-500-page branch April 14, 2023 05:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 14, 2023
* upstream/main:
  Show friendly 500 error page to users and developers (go-gitea#24110)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested 500 page inside a page
7 participants