Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for commit count on releases page #24157

Closed

Conversation

oliverpool
Copy link
Contributor

should fail until #24148 is merged

To add relevant test for commit count on releases pages, I first had to add some commits to the user2/repo1.

Graph before e4ae72b6984a27a9ebcf074fd77e9c1f0f6a9e67
2023-04-17-004558

Graph after e4ae72b6984a27a9ebcf074fd77e9c1f0f6a9e67
2023-04-17-004514

This allows to have a positive number of commits since a release (release v0.1 in this case).

@techknowlogick
Copy link
Member

As this is a test in relation to the other PR could you combine the two?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2023
@oliverpool
Copy link
Contributor Author

@techknowlogick ideally yes. However adding the test is quite challenging (I could add one "quickly", but showing -9 commits to master seems wrong).

I would prefer for the test not to delay the bugfix.
The goal of this test is also to easily be extended for #24145

@oliverpool
Copy link
Contributor Author

Modifying the existing tests is to cumbersome.

I add a dedicated user2/repo-release test repository (directly in #24148)

@oliverpool oliverpool closed this Apr 17, 2023
@oliverpool oliverpool deleted the preprend_commits_user2_repo1 branch April 17, 2023 13:22
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants