Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect internal response type #24173

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Fix incorrect internal response type #24173

merged 2 commits into from
Apr 18, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Apr 17, 2023 •
edited
Loading

Close #24167

The endpoint "set-default-branch" returns success, so just decode it as responseText

Confirmed by #24167 (comment)

@wxiaoguang wxiaoguang mentioned this pull request Apr 17, 2023
Closed
@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 17, 2023
@silverwind
Copy link
Member

silverwind commented Apr 17, 2023 •
edited
Loading

Would it be hard to add a test? Does seem like a common use case.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 17, 2023
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Apr 18, 2023 •
edited
Loading

Quite difficult. It's not a common problem, just a typo, and at least it doesn't cause serious problem.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2023
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) April 18, 2023 02:44
@techknowlogick
Copy link
Member

🤖 🎺

@techknowlogick techknowlogick merged commit 2979041 into go-gitea:main Apr 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2023
@wxiaoguang wxiaoguang deleted the fix-git-hook-set-branch branch April 18, 2023 03:21
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Error when pushing to new repo: Internal Server Response Decoding Failed
6 participants
@wxiaoguang @silverwind @techknowlogick @lunny @yardenshoham @GiteaBot