Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong scopes of locale.PrettyNumber #24181

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Fix wrong scopes of locale.PrettyNumber #24181

merged 1 commit into from
Apr 18, 2023

Conversation

HesterG
Copy link
Contributor

@HesterG HesterG commented Apr 18, 2023

Fix the scopes for locale.PrettyNumber on repo project list and user dashboard milestone list. Regression from #24134

截屏2023-04-18 15 50 33

截屏2023-04-18 15 46 14

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 18, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 18, 2023
@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 18, 2023
@yardenshoham yardenshoham added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 18, 2023
@wxiaoguang
Copy link
Contributor

That's why we need this:

@lunny lunny merged commit 6f3c162 into go-gitea:main Apr 18, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 18, 2023
@HesterG HesterG deleted the fix-locale-prettynum branch April 18, 2023 11:39
@HesterG HesterG restored the fix-locale-prettynum branch April 19, 2023 01:12
@HesterG HesterG deleted the fix-locale-prettynum branch April 19, 2023 01:12
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yardenshoham yardenshoham yardenshoham approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@HesterG @wxiaoguang @lunny @yardenshoham @GiteaBot