Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JS dependencies #24218

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Update JS dependencies #24218

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0c4db5e
Update JS dependencies
silverwind Apr 19, 2023
08bcebf
restart ci
silverwind Apr 19, 2023
db69817
Merge branch 'main' into deps-49
GiteaBot Apr 19, 2023
6595fc9
update to go 1.20.3, avoid tempfile during install
silverwind Apr 19, 2023
d5a30a7
dynamically determine latest go version
silverwind Apr 19, 2023
0d8ce2f
track latest stable go
silverwind Apr 19, 2023
5ab05f2
fix tar destination
silverwind Apr 19, 2023
d7e8b08
use version sort
silverwind Apr 19, 2023
6ac47c5
revert to focal because of crashes
silverwind Apr 19, 2023
4abd4ed
Merge branch 'main' into deps-49
techknowlogick Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,7 @@ steps:

# TODO: We should probably build all dependencies into a test image
- name: test-e2e
image: mcr.microsoft.com/playwright:v1.32.1-focal
image: mcr.microsoft.com/playwright:v1.32.3-jammy
commands:
- curl -sLO https://go.dev/dl/go1.20.linux-amd64.tar.gz && tar -C /usr/local -xzf go1.20.linux-amd64.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump this version of go?

Copy link
Member Author

@silverwind silverwind Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a shame golang does not provide stable download links to latest patch release, but we may be able to do some curl+jq magic with https://go.dev/dl/?mode=json.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not as easy as I had hoped, the json only contains latest two supported versions, no structure to select only 1.20.x.

curl 'https://go.dev/dl/?mode=json' | fx

image

Copy link
Member

@jolheiser jolheiser Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaik it (the newest version) should always be the first result, though

Copy link
Member Author

@silverwind silverwind Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but i guess we don't always want latest and assuming we are two versions behind it will fail completely, so this needs a more involved script.

Update to 1.20.3 in 6595fc9.

Copy link
Member Author

@silverwind silverwind Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made it dynamic in d5a30a7.

It will now track the latest stable 1.20 version of go with this. I could also make it just always use the highest stable version to make this completely maintenaince-free.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done that, now tracking highest stable.

- groupadd --gid 1001 gitea && useradd -m --gid 1001 --uid 1001 gitea
Expand Down
4 changes: 2 additions & 2 deletions .eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ rules:
curly: [0]
custom-elements/expose-class-on-global: [0]
custom-elements/extends-correct-class: [2]
custom-elements/file-name-matches-element: [0]
custom-elements/file-name-matches-element: [2]
custom-elements/no-constructor: [2]
custom-elements/no-customized-built-in-elements: [2]
custom-elements/no-dom-traversal-in-attributechangedcallback: [2]
Expand Down Expand Up @@ -500,7 +500,7 @@ rules:
unicorn/prefer-default-parameters: [0]
unicorn/prefer-event-key: [2]
unicorn/prefer-event-target: [2]
unicorn/prefer-export-from: [2]
unicorn/prefer-export-from: [2, {ignoreUsedVariables: true}]
unicorn/prefer-includes: [2]
unicorn/prefer-json-parse-buffer: [0]
unicorn/prefer-logical-operator-over-ternary: [2]
Expand Down
Loading