Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue attachment handling (#24202) #24221

Merged

Conversation

wxiaoguang
Copy link
Contributor

Backport #24202

Close #24195

Fix the bug:

  1. The old code doesn't handle removedfile event correctly
  2. The old code doesn't provide attachments for type=CommentTypeReview

# Conflicts:
#	templates/repo/issue/view_content.tmpl
#	templates/repo/issue/view_content/attachments.tmpl
#	web_src/css/features/dropzone.css
#	web_src/js/features/repo-legacy.js
@wxiaoguang wxiaoguang force-pushed the fix-issue-attachment-1.19 branch from d716b70 to 1d5a273 Compare April 20, 2023 03:19
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 20, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2023
@lunny lunny added this to the 1.19.2 milestone Apr 20, 2023
@lunny lunny added the type/bug label Apr 20, 2023
@silverwind silverwind enabled auto-merge (squash) April 20, 2023 07:25
@silverwind silverwind merged commit d5f2c9d into go-gitea:release/v1.19 Apr 20, 2023
@wxiaoguang wxiaoguang deleted the fix-issue-attachment-1.19 branch April 20, 2023 08:28
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants