Refresh the refernce of the closed PR when reopening #24231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sillyguodong
changed the title
silverwind
added
type/bug
outdated/backport/v1.19
lunny
reviewed
Apr 20, 2023
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Apr 20, 2023
|
@sillyguodong please make sure to resolve resolved conversations. |
wolfogre
approved these changes
May 4, 2023
GiteaBot
added
lgtm/need 1
pull-request-size
bot
added
the
size/M
lunny
approved these changes
May 8, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 8, 2023
Close go-gitea#24213 Replace go-gitea#23830 #### Cause - Before, in order to making PR can get latest commit after reopening, the `ref`(${REPO_PATH}/refs/pull/${PR_INDEX}/head) of evrey closed PR will be updated when pushing commits to the `head branch` of the closed PR. #### Changes - For closed PR , won't perform these behavior: insert`comment`, push `notification` (UI and email), exectue [pushToBaseRepo](https://github.com/go-gitea/gitea/blob/74225033413dc0f2b308bbe069f6d185b551e364/services/pull/pull.go#L409) function and trigger `action` any more when pushing to the `head branch` of the closed PR. - Refresh the reference of the PR when reopening the closed PR (**even if the head branch has been deleted before**). Make the reference of PR consistent with the `head branch`.
silverwind
pushed a commit
that referenced
this pull request
May 8, 2023
Backport #24231 by @sillyguodong Close #24213 Replace #23830 #### Cause - Before, in order to making PR can get latest commit after reopening, the `ref`(${REPO_PATH}/refs/pull/${PR_INDEX}/head) of evrey closed PR will be updated when pushing commits to the `head branch` of the closed PR. #### Changes - For closed PR , won't perform these behavior: insert`comment`, push `notification` (UI and email), exectue [pushToBaseRepo](https://github.com/go-gitea/gitea/blob/74225033413dc0f2b308bbe069f6d185b551e364/services/pull/pull.go#L409) function and trigger `action` any more when pushing to the `head branch` of the closed PR. - Refresh the reference of the PR when reopening the closed PR (**even if the head branch has been deleted before**). Make the reference of PR consistent with the `head branch`. Co-authored-by: sillyguodong <33891828+sillyguodong@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 9, 2023
* upstream/main: Add Gitea Profile Readmes (go-gitea#23260) Make diff view full width again (go-gitea#24598) Add permission check for moving issue action in project view page (go-gitea#24589) Update JS dependencies, add new eslint rules (go-gitea#24597) Filters for GetAllCommits (go-gitea#24568) [skip ci] Updated translations via Crowdin Attach a tooltip to the action control button (go-gitea#24595) Improve Gitea's web context, decouple "issue template" code into service package (go-gitea#24590) Support markdown editor for issue template (go-gitea#24400) Do not select line numbers when selecting text from the action run logs (go-gitea#24594) In TestViewRepo2, convert computed timezones to local time (go-gitea#24579) Fix close org projects (go-gitea#24588) Rewrite queue (go-gitea#24505) Split "modules/context.go" to separate files (go-gitea#24569) Pass 'not' to commit count (go-gitea#24473) Refresh the refernce of the closed PR when reopening (go-gitea#24231)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #24213
Replace #23830
Cause
ref(${REPO_PATH}/refs/pull/${PR_INDEX}/head) of evrey closed PR will be updated when pushing commits to thehead branchof the closed PR.Changes
comment, pushnotification(UI and email), exectue pushToBaseRepo function and triggeractionany more when pushing to thehead branchof the closed PR.head branch.