Ensure "ref" parameter is not ignored in function RepoRefForAPI #24242
+42
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there looks to be an underlying issue about our handler ... in this case that fix just did it and since we only need the API context here anyways it simplify the code :) |
GiteaBot
added
the
lgtm/need 2
6543
changed the title
What issue? Is it related to #24080 ? If yes, I will fix it. |
|
Could you add some tests? |
|
I think I know the problem of this issue, it is related to #24080 , I am working on it. |
|
@wxiaoguang the lastest changes fix it ... I will create a new pull that contains the test I used to determine it :) |
|
-> #24388 |
silverwind
pushed a commit
that referenced
this pull request
Apr 29, 2023
This pull request adds an integration test to validate the behavior of raw content API's reference handling for all supported formats . close #24242 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before
http://localhost:3000/api/v1/repos/test/aaa/raw/.woodpecker.ymlhttp://localhost:3000/api/v1/repos/test/aaa/raw/500c8e1f4c3d33c1d6990c5498db0f0a02136cc5/.woodpecker.ymlhttp://localhost:3000/api/v1/repos/test/aaa/raw/.woodpecker.yml?ref=500c8e1f4c3d33c1d6990c5498db0f0a02136cc5after all work