Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label color, fix divider in dropdown (#24215) #24244

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Fix label color, fix divider in dropdown (#24215) #24244

merged 1 commit into from
Apr 21, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #24215 by @silverwind

Two small CSS fixes:

  1. Fix basic primary label hover:

Before:
Screenshot 2023-04-19 at 20 00 32

After:
Screenshot 2023-04-19 at 20 05 29

  1. Fix border color of divider in dropdown and remove margin so it looks better with hover effect, as discussed in Make wiki title supports dashes and improve wiki name related features #24143:

Screenshot 2023-04-19 at 20 03 24

Screenshot 2023-04-19 at 20 03 55

@silverwind @GiteaBot
Fix label color, fix divider in dropdown (go-gitea#24215)
22c22d9 
Two small CSS fixes:

1. Fix basic primary label hover
2. Fix border color of divider in dropdown and remove margin so it looks
better with hover effect, as discussed in
go-gitea#24143:
@GiteaBot GiteaBot added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Apr 21, 2023
@GiteaBot GiteaBot added this to the 1.19.2 milestone Apr 21, 2023
@GiteaBot GiteaBot requested review from jolheiser and lunny April 21, 2023 01:53
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 21, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2023
@jolheiser jolheiser merged commit 7117355 into go-gitea:release/v1.19 Apr 21, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
@techknowlogick techknowlogick deleted the backport-24215-v1.19 branch September 9, 2023 05:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@lunny lunny lunny approved these changes

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.19.2
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @jolheiser @silverwind