Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove less/_repository.less #24467

Merged
merged 1 commit into from
May 1, 2023
Merged

Remove less/_repository.less #24467

merged 1 commit into from
May 1, 2023

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added this to the 1.19.3 milestone May 1, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 1, 2023
delvh
delvh approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@delvh delvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When was that re-added?
I don't have it on my local state that's at most a hundred commits behind main…

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2023
lunny
lunny approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because #23508 missed this file.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2023
yardenshoham
yardenshoham suggested changes May 1, 2023
View reviewed changes
Copy link
Member

@yardenshoham yardenshoham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on v1.19

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels May 1, 2023
@lunny
Copy link
Member

lunny commented May 1, 2023 •
edited
Loading

This should also be sent to main branch.

@yardenshoham yardenshoham self-requested a review May 1, 2023 14:03
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels May 1, 2023
silverwind
silverwind approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this was missed somehow.

@silverwind silverwind enabled auto-merge (squash) May 1, 2023 14:05
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 1, 2023
@silverwind silverwind merged commit 84fa30e into go-gitea:release/v1.19 May 1, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 1, 2023
@wxiaoguang wxiaoguang deleted the remove-less branch May 1, 2023 14:46
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

@lunny lunny lunny approved these changes

@yardenshoham yardenshoham Awaiting requested review from yardenshoham

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.19.3
Development

Successfully merging this pull request may close these issues.
6 participants
@wxiaoguang @lunny @silverwind @yardenshoham @delvh @GiteaBot