Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable PATs until next release #24527

Merged
merged 3 commits into from
May 5, 2023
Merged

Temporarily disable PATs until next release #24527

merged 3 commits into from
May 5, 2023

Conversation

kdumontnu
Copy link
Contributor

This might be a bit contentious, but I think we should try to limit the impact of deprecating scoped PATs with the rewrite proposed here we're working on for v1.20: #24501

We should have a PR opened shortly to re-scope the routes.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 5, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2023
@delvh delvh added this to the 1.20.0 milestone May 5, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 5, 2023
@delvh
Copy link
Member

delvh commented May 5, 2023

So, I can see two options after this PR:

  1. The replacement PR is merged in time.
  2. The replacement PR is not merged in time, and this PR will be reverted.

Another thing to note is that handling the already existing scoped PATs will be absolutely horrifying.

@kdumontnu
Copy link
Contributor Author

So, I can see two options after this PR:

  1. The replacement PR is merged in time.
  2. The replacement PR is not merged in time, and this PR will be reverted.

Another thing to note is that handling the already existing scoped PATs will be absolutely horrifying.

Well, we have a few options:

  • Migrate existing scoped PATs to new ones (kind of annoying)
  • Backport this to 1.19.3 and announce a breaking change, then reject all of the old scope tokens in 1.20 (so that users have to regenerate them)

@delvh
Copy link
Member

delvh commented May 5, 2023

Backport this to 1.19.3 and announce a breaking change, then reject all of the old scope tokens in 1.20 (so that users have to regenerate them)

I don't see this as a viable option.
That is a huge violation of semver, for an outcome that is not yet known.

Migrate existing scoped PATs to new ones (kind of annoying)

I know, but I see that as the only viable option here.

@techknowlogick techknowlogick added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label May 5, 2023
@techknowlogick
Copy link
Member

Throwing a breaking label on this PR so it gets reviewed again when writing the next blog post in case the proposed solution above doesn't come about in time.

@techknowlogick techknowlogick merged commit 09dd4b4 into go-gitea:main May 5, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 5, 2023
@kdumontnu kdumontnu deleted the kd/deprecate_scoped_PATs branch May 5, 2023 18:03
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 6, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
1c9bfb1 
* upstream/main:
  Add RPM registry (go-gitea#23380)
  Docs for Gitea Actions (go-gitea#24405)
  Update LDAP filters to include both username and email address (go-gitea#24547)
  Temporarily disable PATs until next release (go-gitea#24527)
  Replace placeholders in licenses (go-gitea#24354)
  Fix the permission of team's `Actions` unit issue (go-gitea#24536)
  Bump golang deps (go-gitea#24533)
  Fix mirrors repository disapeared on user dashboard (go-gitea#24520)
  Revert "Prevent a user with a different email from accepting the team invite" (go-gitea#24531)
  Fix form method/class (go-gitea#24535)
  Fix typo in rename branch dialog (go-gitea#24537)
  Check length of `LogIndexes` in case it is outdated (go-gitea#24516)
@delvh delvh mentioned this pull request May 18, 2023
Closed
@delvh delvh removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Jun 1, 2023
@delvh
Copy link
Member

delvh commented Jun 1, 2023

Looks like we'll be able to get the new design merged, hence removing the breaking label.

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kdumontnu @delvh @techknowlogick @wxiaoguang @GiteaBot