Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kd/fix redis unit test #24650

Merged
merged 3 commits into from
May 11, 2023
Merged

Kd/fix redis unit test #24650

merged 3 commits into from
May 11, 2023

Conversation

kdumontnu
Copy link
Contributor

@kdumontnu kdumontnu commented May 10, 2023

Replaces #24641

Currently, unit tests fail when run locally (unless users have minio instance running). This PR only requires redis unit tests if in CI.

  • Only run redis unit tests when CI env variable is set
  • Add minio as a service in unit tests actions

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 10, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2023
@lunny lunny merged commit a54c8b4 into go-gitea:main May 11, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 11, 2023
@kdumontnu kdumontnu deleted the kd/fix-redis_unit_test branch May 11, 2023 02:20
@wxiaoguang
Copy link
Contributor

Thank you.

That's what I planned to do but haven't done yet 😁

I think in the future we can use redis to test more code, eg: cache? session?

zjjhot added a commit to zjjhot/gitea that referenced this pull request May 12, 2023
* upstream/main:
  GitHub Actions cleanups (go-gitea#24620)
  Fix issues list page multiple selection update milestones (go-gitea#24660)
  Make repo migration cancelable and fix various bugs (go-gitea#24605)
  Improve queue & process & stacktrace (go-gitea#24636)
  Fix missing badges in org settings page (go-gitea#24654)
  Only show one tippy at a time (go-gitea#24648)
  Reenable creating default webhooks. (go-gitea#24626)
  Kd/fix redis unit test (go-gitea#24650)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants